terrylinooo / githuber-md

Markdown editor plugin for WordPress.
GNU General Public License v3.0
604 stars 88 forks source link

Shortcodes with quotes are broken #317

Closed nbelyh closed 10 months ago

nbelyh commented 1 year ago

Describe the bug

If you use a shortcode like this then it works:

[row class=row]

But if you use a shortcode like this, then it fails (the quote gets double-encoded)

[row class="row"]

To reproduce

I use Fluida theme that provides custom shortcodes. If I use "button" shortcode like this, the button is rendered correctly.

[button size=md type=primary href=https://google.com]Open Google[/button]

But if I do it like this, then the rendering is broken (the parameters are passed together with quotes).

[button size="md" type="primary" href="https://google.com"]Open Google[/button]

I would avoid quotes, but some parameters have space inside.

Expected behavior

Both cases should work.

Screenshots

image

Server environment

User environment

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 2 days.

github-actions[bot] commented 10 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.