search

terrylinooo / githuber-md

Markdown editor plugin for WordPress.
GNU General Public License v3.0
604 stars 88 forks source link

Preferences: Link Opening Method affects internal blog posts navigation #348

Closed Moodjbow closed 4 months ago

Moodjbow commented 6 months ago

Describe the bug

When Link Opening Method is set to "New Window", it forces the list of blogs on the home page to open in new tabs. When changed to "Same Window (default," the normal WordPress behavior is re-established.

To reproduce

Steps to reproduce the behavior:

  1. If the issue is dependent on the theme (not researched), under Appearance / Themes, add and activate "Twenty Twenty-one". No customizations needed.
  2. Under Settings / Reading, configure "Blog pages show at most" = 10 posts; and configure "For each post in a feed, include" = excerpt.
  3. Under Settings / WP Githuber MD / Preferences / Link Opening Method, select New Window, and save.
  4. In a separate window, navigate to the root URI of your WP instance and confirm that you have a list of posts with titles, excerpt, and "Continue reading" links. Hover over the Title and "Continue reading" and confirm that they contain the permalinks to the post. A click on any of it should open the post on a new browser tab.
  5. Under Settings / WP Githuber MD / Preferences / Link Opening Method, select Same Window (default), and save.
  6. Refresh the separate window and navigate back to the root URI. Now a click on the title or "Continue reading" should open the post in the same browser tab.

Expected behavior

As per my understanding "For links in posts, please specify where to open the linked document" presumes external links in a post (i.e. referencing external sources and not another posts in the same WP instance". Ideally the target="_blank" attribute in an object should be added only to links in the post not containing the root URI of the same site/WP instance. But at bare minimum, this Preference should not affect the navigation between the posts.

Screenshots

n/a

Server environment

  • WordPress version [ 6.1.1 ]
  • WP Githuber MD plugin version [ 1.16.3 ]
  • PHP version [ 8.0.28 ]

User environment

  • OS: [ Linux / Synology DSM 7.2.1]
  • Browser [Chrome]

Additional context

n/a

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 2 days.

github-actions[bot] commented 4 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.