Closed szepeviktor closed 4 years ago
Merging #26 into 2.x will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## 2.x #26 +/- ##
=========================================
Coverage 99.97% 99.97%
Complexity 1175 1175
=========================================
Files 88 88
Lines 3988 3987 -1
=========================================
- Hits 3987 3986 -1
Misses 1 1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/Firewall/Kernel/SessionTrait.php | 100.00% <ø> (ø) |
16.00 <0.00> (ø) |
|
src/Firewall/Session.php | 100.00% <100.00%> (ø) |
28.00 <0.00> (ø) |
|
src/Firewall/Kernel/TemplateTrait.php | 100.00% <0.00%> (ø) |
21.00% <0.00%> (ø%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4a9b6a3...677e781. Read the comment docs.
Thank you. I will reivew your contribution later.
Unit testing failed. I will carefully check them one by one.
I'm sorry, I thought Scrutinizer runs the unit tests.
@szepeviktor It's okay. Thank you very much for contributing. I have just implemented GitHub Action, it may help to check the PRs. This PR is closed becasue too many changes. It is better to split them into serveral small PRs. You can also do unit testing for the changes. Here is the step by step guide: https://github.com/terrylinooo/shieldon/wiki/Contributing
Okay! You can still pick changes by hand.
@terrylinooo Fix various errors, make the code shorter and more readable.