terrylinooo / shieldon

Web Application Firewall (WAF) for PHP.
https://shieldon.io
MIT License
838 stars 96 forks source link

fixing remove button behaviour in Authentication settings #32

Closed patrickhafner closed 1 year ago

patrickhafner commented 3 years ago

On "authentication settings" page (/firewall/panel/security/authentication/) entries can not be removed. The POST params check fails, because following attributes are empty:

Also the checkPostParamsExist function will fail if the value to be checked is "0" or 0 regarding php documentation:

The following values are considered to be empty:

"" (an empty string) 0 (0 as an integer) 0.0 (0 as a float) "0" (0 as a string) ...

From https://www.php.net/manual/en/function.empty.php

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 14 days.