search

terrymacdonald / DisplayMagician

DisplayMagician is an open source tool for automatically configuring your displays and sound for a game or application from a single Windows Shortcut.
https://displaymagician.littlebitbig.com
GNU General Public License v3.0
424 stars 17 forks source link

DM 2.6.0.446 not opening after installation (may be not a bug?) #283

Open sk666 opened 8 months ago

sk666 commented 8 months ago

Describe the bug I installed the 2.6 version over 2.5.xxx and did a reboot after the installation. After the reboot, I was unable to start it with windows, I was unable to open it manually and I was unable to do the repair in the control pannel. So this ticket is only for your information for futur troubelshoot/investigation. Beacause of that, unfortunately I don't have any logs from DM 2.6 version for this bug.

To fix it, I removed the 2.6 version, manually delete de DM folder in appdata/local, rebooted the computer, install the 2.6 version again, did a second reboot and now it open normally. I did not have the time to fully test it, I will do it later today.

You can close this ticket if you want, problem is solved now for me.

Thank you for your great work Terry :)

FYI: w10 x64 22h2 fully updated Nvidia RTX3060

terrymacdonald commented 8 months ago

Hmmmm. I think I'll have to uninstall my v2.6, then do a whole heap of testing to see if I can break the v2.5 to v2.6 upgrade. I'm hoping that it was just an issue with your build, but it is very possible it isn't :(. I'll see if I can find anything.

Thanks for bringing this to my attention, and thanks for your kind words!

Terry

terrymacdonald commented 8 months ago

Another user has experienced the same issues upgrading from 2.5.0, so I will need to do some more testing this weekend. I'm pretty busy so it may be a few days before I can get time to fix this all.

sk666 commented 8 months ago

No problem Terry, this problem is fixed for me. Let me know if you need help :)

sk666 commented 7 months ago

A little update on the 2.6 version. I discovered yesterday that it does not close applications when I turn off surround like it was supposed to do in my case. Do you need log for this?

terrymacdonald commented 7 months ago

Yes please. Can you also upload a Support ZIP File so I can see what's going on? It will help me look at the right bit of code.

I've also discovered an error in the way that the test version was applying each display profile. It was missing applying the AMD configuration if someone has an NVIDIA card and an AMD iGPU. I've fixed that in code so it works now, but I still am testing the upgrade error you logged here.

Thanks Terry

On Sun, 28 Jan 2024, 00:39 sk666, @.***> wrote:

A little update on the 2.6 version. I discovered yesterday that it does not close applications when I turn off surround like it was supposed to do in my case. Do you need log for this?

— Reply to this email directly, view it on GitHub https://github.com/terrymacdonald/DisplayMagician/issues/283#issuecomment-1913128534, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLU5LE7P4SK4A6IN5MJDIDYQTRPXAVCNFSM6AAAAABCHJBT32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGEZDQNJTGQ . You are receiving this because you were assigned.Message ID: @.***>

terrymacdonald commented 7 months ago

@sk666 I did find some issues with the earlier v2.6.0.446 version. I've made a lot of revisions to how DisplayMagician works in v2.6.0.485 (attached) that should make it way more reliable. But it is highly likely you will need to 'update' your Display Profiles to make them work properly.

I'd recommend first of all applying a Display Profile, and then press the 'update' button. That will recreate the config for the Display Profile and should make it work properly. You'll need to do that to each of your saved Display Profiles. Then please test out changing between your Display Profiles to see if everything works as expected.

Here is the latest test version of DisplayMagician: DisplayMagicianSetup-v2.6.0.485.zip

Thanks for all your help testing.

Terry

terrymacdonald commented 7 months ago

@sk666 I've tried one two different computers to debug that error you were getting, but I think my combination of hardware isn't correct to cause an issue :(. I think I need some examples of other peoples config files to test with,

I know that you are having issues, so can you please ZIP up your current DisplayMagician folder into a ZIP file, and then upload it here? I will then replace my own installation with your test files and see if I can make things break. You didn't happen to save your older files that were causing the issue did you? Maybe they're in your recycle bin? Having those files would be the best chance to find this pesky bug.

A fresh DisplayMagician v2.5 install doesn't make things break unfortunately, so it could be a bug that an earlier version of DM introduced into the files? Can you remember what the first version of DisplayMagician you used was? I can try installing the oldest version and continue upgrading to see if that has introduced an error somewhere...

Thanks Terry

terrymacdonald commented 7 months ago

@sk666 Do you know if you have installed the .Net Framework 4.8.1 runtime on your PC? Version 2.6.0 of DisplayMagician uses .Net Framework 4.8.1, and I'm wondering if that's part of the reason it didnt show anything? I've been trying to find out what could have caused the issue, but I haven't been able to trigger it, so it's looking more like something that comes up on other computers, as none of my test computers demonstrate any issues :/. This is a frrustrating thing to troubleshoot.

FYI I've produced a new test version of DisplayMagician that I just compiled with some extra bugfixes I updated last night: DisplayMagicianSetup-v2.6.0.492.zip

Can you please update again and make sure that works for you? Functionally this version is nearly ready to ship I think, but I can't do that until I squash that upgrade bug! All I need is a break with some sort of error message and I can fix it.

Thanks Terry

sk666 commented 7 months ago

Hi Terry,

Sorry for my late response. I will check this out later this week. But I' pretty sure that I don't have the net framework 4.8.1

I will test DM .492 at the same time before collecting logs. Last time I played my games, DM was able to close 1 of my 2 programs that is supposed to exit after turning off surround, instead a 100% failure the other times. DM was not able to exit logitech LG Hub (used for my g29).

Also, do you know if it's possible (and if yes, how ?) to close steam with DM after tunring off surround?

I hope I will be able to test this befor friday this week but I'm not sure.

Thank you

Obtenir Outlook pour Androidhttps://aka.ms/AAb9ysg

From: terrymacdonald @.> Sent: Monday, January 29, 2024 2:04:55 AM To: terrymacdonald/DisplayMagician @.> Cc: sk666 @.>; Mention @.> Subject: Re: [terrymacdonald/DisplayMagician] DM 2.6.0.446 not opening after installation (may be not a bug?) (Issue #283)

@sk666https://github.com/sk666 Do you know if you have installed the .Net Framework 4.8.1 runtime on your PC? Version 2.6.0 of DisplayMagician uses .Net Framework 4.8.1, and I'm wondering if that's part of the reason it didnt show anything? I've been trying to find out what could have caused the issue, but I haven't been able to trigger it, so it's looking more like something that comes up on other computers, as none of my test computers demonstrate any issues :/. This is a frrustrating thing to troubleshoot.

FYI I've produced a new test version of DisplayMagician that I just compiled with some extra bugfixes I updated last night: DisplayMagicianSetup-v2.6.0.492.ziphttps://github.com/terrymacdonald/DisplayMagician/files/14078483/DisplayMagicianSetup-v2.6.0.492.zip

Can you please update again and make sure that works for you? Functionally this version is nearly ready to ship I think, but I can't do that until I squash that upgrade bug! All I need is a break with some sort of error message and I can fix it.

Thanks Terry

— Reply to this email directly, view it on GitHubhttps://github.com/terrymacdonald/DisplayMagician/issues/283#issuecomment-1914081652, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5ULZKNU5O4J2NNIL3LUGTYQ5CZPAVCNFSM6AAAAABCHJBT32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGA4DCNRVGI. You are receiving this because you were mentioned.Message ID: @.***>

terrymacdonald commented 7 months ago

No problem for any delay in replying. We're all volunteers and life has a habit of getting in the way. Take as much time to test as you need.

When I read your comment, were you talking about the Start Programs (those helper applications that you want to run just while the main game is running)? If so, then DisplayMagician is only able to stop the same application exe that it starts up. Some applications use a different starting exe that then loads and ruins the main application exe before the starting exe exits. In this case, DisplayMagician doesn't know that the main application is still running, and instead thinks that the exe it started has been closed. It kind of sounds like that might be happening in your case.

The only workaround is to add a command line that closes lgHUB.exe to the 'Run a command afterwards' section that will find and kill the lgHub.exe process.

As for turning off Steam afterwards, you could do that in that same 'Run a command afterwards' section, but you would need to probably do it in a powershell or batch file as you'll have two things you want to do at once, and DM currently only supports one afterwards command at the moment.

Hopefully that answers your questions.

Thanks Terry

Message ID: @.*** com>

sk666 commented 7 months ago

Hum I don't really remember the interface of display magician, I don't have my computer in the moment. What I did is I added 2 programs to start before launching the game (lghub and simdashboard), both are them are usually off so I ask DM to start them and don't start it if they are already running (may be I can remove that last setting because it's never happened to have them started before the game, may be it's the issue), and I checked the box to close both of them when exit surround.

I will try to add the command line to kill it in my nircmd script to see if he can handle this too, with my "primary taskbar position script" that I talked before in the other post. If it's not possible, I can live with this lghub not closing. I was just curious how he can start it and why he is not able to kill it after surround exit.

Do.you know what will be the command line to find lghub and how to kill it in cmd? If tou don't know, I will find them friday so don't worry.

Obtenir Outlook pour Androidhttps://aka.ms/AAb9ysg

From: terrymacdonald @.> Sent: Monday, January 29, 2024 9:11:28 PM To: terrymacdonald/DisplayMagician @.> Cc: sk666 @.>; Mention @.> Subject: Re: [terrymacdonald/DisplayMagician] DM 2.6.0.446 not opening after installation (may be not a bug?) (Issue #283)

No problem for any delay in replying. We're all volunteers and life has a habit of getting in the way. Take as much time to test as you need.

When I read your comment, were you talking about the Start Programs (those helper applications that you want to run just while the main game is running)? If so, then DisplayMagician is only able to stop the same application exe that it starts up. Some applications use a different starting exe that then loads and ruins the main application exe before the starting exe exits. In this case, DisplayMagician doesn't know that the main application is still running, and instead thinks that the exe it started has been closed. It kind of sounds like that might be happening in your case.

The only workaround is to add a command line that closes lgHUB.exe to the 'Run a command afterwards' section that will find and kill the lgHub.exe process.

As for turning off Steam afterwards, you could do that in that same 'Run a command afterwards' section, but you would need to probably do it in a powershell or batch file as you'll have two things you want to do at once, and DM currently only supports one afterwards command at the moment.

Hopefully that answers your questions.

Thanks Terry

Message ID: @.*** com>

— Reply to this email directly, view it on GitHubhttps://github.com/terrymacdonald/DisplayMagician/issues/283#issuecomment-1915935553, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5ULZLRHBL4FOE3TCDU6ALYRBJFBAVCNFSM6AAAAABCHJBT32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVHEZTKNJVGM. You are receiving this because you were mentioned.Message ID: @.***>

sk666 commented 7 months ago

Hi Tery,

I was able to test it today. But sorry for you, bad news about the .492 version. It wont open at all after installation over .446, even after the reboot, no logs file. I will need to remove it and use the .446.

I'm pretty sure that I don't had the .net framework 4.8.1 so I install it before this test (with a reboot).

I'm not sure what to test now. I will use the .446 for the next days when I will use it.

terrymacdonald commented 7 months ago

Thanks @sk666,

Thanks to some help from @ganzoni I think I know what's happening, and I'm currently developing a fix for that. I've attached a new test version of DisplayMagician to this, and hopefully it works ok for you.

DisplayMagicianSetup-v2.6.0.505.zip

The fix has the following checks in it:

Previously only the first check was being done, and that would cause issues in desktop PCs with only one vendors card, or in gaming laptops with both AMD and NVIDIA. I'm hoping this will now work.

Thanks Terry

sk666 commented 7 months ago

Hi Terry,

Build 505 wont start on my computer. No splashscreen, no syst tray DM icon, no process etc.

terrymacdonald commented 7 months ago

Damn it! It's working on @ganzoni's computer, but not quite. There must be a slight different big with running on yours.

I wonder if windows smartscreen or windows defender are stopping it from running or something like that? I'll try doing some more testing on the last test machine I have. It's an NVIDIA only machine like you have. There may be a logic bug still there somewhere.

Thanks for testing again! This will really help in the long run.

Thanks Terry

On Thu, 1 Feb 2024, 06:35 sk666, @.***> wrote:

Hi Terry,

Build 505 wont start on my computer. No splashscreen, no syst tray DM icon, no process etc.

— Reply to this email directly, view it on GitHub https://github.com/terrymacdonald/DisplayMagician/issues/283#issuecomment-1919586456, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLU5LBQDWYTFYXCWU3A4D3YRJ6FFAVCNFSM6AAAAABCHJBT32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGU4DMNBVGY . You are receiving this because you were assigned.Message ID: @.***>

sk666 commented 7 months ago

For your information, I did a system resrore with my last ghost, so I tested to insyall .505 build over this 2.5 version, may be it can cause the glitch. Or may be not. I installed again .net framewotk 4.8.1 for the 505 build but it wont start it. If i'm not wrong, defender is turned off because I have an independant antivirus software.

terrymacdonald commented 7 months ago

ok @sk666, I've added in more checks and logic to avoid crashes. Could you please try this version? DisplayMagicianSetup-v2.6.0.508.zip

I'm hoping this will work, but at the very least it should allow DisplayMagician to boot up enough for you to create a Support ZIP File. Let's see whether I've fixed it 🤞.

terrymacdonald commented 7 months ago

@sk666 Here is a new test version of DisplayMagician. It only uses the CCD API to set the windows positions. I want to see if that helps make setting the taskbar position more reliable or not. Please check it out and report your findings back. You can uninstall this test version then reinstall the previous version again once you're done as it doesn't do anything to the display profile settings.

DisplayMagicianSetup-v2.6.0.512-no-gdi2.zip

Thanks Terry

terrymacdonald commented 7 months ago

@sk666 The latest test version should be working properly, and hopefully fixes your issue. Could you please test it for me so I know that it fixes your issue? If it does then I'll be able to close this issue as the fix will be part of the next full release.

DisplayMagicianSetup-V2.6.0.515-No-NvApi_SetDisplayConfig.zip

Thanks!

sk666 commented 7 months ago

Hi Terry,

I will be able to test it next week. I will let you know.

Thank you :)

terrymacdonald commented 7 months ago

Oops I broke the setup with my previous version. This version has a corrected setup that should install everything properly.

DisplayMagicianSetup-v2.6.0.522-corrected-setup.zip

Thanks Terry

sk666 commented 7 months ago

Hi Terry,

we made some progress with build 522. Here the list of good and bad news:

thank you DisplayMagician-Support-20240214-0916.zip

sk666 commented 6 months ago

FYI, DM seem to fail to activate surround only the first time I use it after a reboot/turning ON my computer. For the black after launching the game, it always happens no matter what I try. I not tried yet to revert back to build .446.

terrymacdonald commented 2 months ago

Hi All,

Time for an update.

The fix is in the code and works (also we now support 3rd apps and games added to Steam library too!) but my current hold up is actually in the packaging of the application into a windows installer. I've been testing different ways to do this as the move from .net framework 4.8.1 to .net core 8.0.0 has been a massive change. It has resulted in a completely different set of binaries and dlls and other files being created, as well as a different build process too. This is all taking some time to figure out.

I've gone from a WIXv3 based installer to a windows default installer to an NSIS installer then back to a WIXv4 installer all within the last month. It's necessitated me building a brand new way of handling the desktop background context menu, and even down to which libraries are used within the application. It's been a ton of work.

I'm now down to the last few bugs to iron out, and to finish the new packaging process. I think I should have something ready for everyone to test within the next month (assuming there aren't anymore show stoppers.

My goal is to then send out messages through this issues list to get you all to test some DM v2.6.0 test builds, and then once the major bugs are ironed out I will push out the DM v2.6.0 beta to those users who opted in the beta builds. And then I'll finally push the DM v2.6.0 update to the main user group.

Lastly, I've decided to hold back the NVIDIALibrary update for now until DM v2.7.0 as it requires a LOT more work testing and troubleshooting many errors. The Steam beta client changing file structures has forced my hand here a little bit, so a better NVIDIALibrary will just have to wait for now.

Thanks Terry