search

terrymun / Fluidbox

Replicating and improving the lightbox module seen on Medium with fluid transitions.
http://terrymun.github.io/Fluidbox/
Other
2.15k stars 166 forks source link

Use more verbose transition, which works better with autoprefixer #182

Closed Mesoptier closed 7 years ago

Mesoptier commented 7 years ago

Hiya!

In our project, autoprefixer has been throwing warnings about incorrect CSS in our dependencies, much to the annoyance of @Gaya (and the rest of the team :stuck_out_tongue:). This PR is part of an effort to fix those.

I have replaced the separate transition-*: properties with transition:. This way autoprefixer has no problems with prefixing the transition/transform.

I've tested it in Chrome and it works fine, but I can test in other environments if that's needed.

terrymun commented 7 years ago

If you look into the code, I actually left some comments there about how autoprefixer doesn't deal with certain transition prefixes properly, hence the decision to manually add vendor prefixes instead. Have you tested your update in other environments? So far my issue seems to lie with Safari, if I was not mistaken.

Mesoptier commented 7 years ago

I've tested in Chrome and Firefox on Ubuntu, and in Safari and IE11 via Browserstack. The transitions work fine in all these browsers. And there is no reason why this code wouldn't work, as it just defines the transitions more explicitly instead of relying on some properties that have been set before.

terrymun commented 7 years ago

Sorry for getting back to you late. I have now merged your PR into the master branch, will be releasing a minor version release.

Gaya commented 7 years ago

Thank you @terrymun !

terrymun commented 7 years ago

You're welcome! Has been a bit too busy lately (changing jobs), so a bit behind with maintaining my repos ;) hope all is well on your side!