data-fluidbox-max-width no working correctly.

terrymun / Fluidbox

Replicating and improving the lightbox module seen on Medium with fluid transitions.

http://terrymun.github.io/Fluidbox/

Other

2.15k stars 166 forks source link

data-fluidbox-max-width no working correctly. #186

Closed bennyb closed 7 years ago

bennyb commented 7 years ago

Hoping to give each elements it's own max width as some I need to allow for some caption text to the right. But setting the max-width data attribute seems to make the image shrink when clicked.

See example. https://jsfiddle.net/bennyb/f3z8f2kz/

terrymun commented 7 years ago

I confirm that the is a bug. This is due to the erroneous coercing of HTML5 data- attribute values into true, when it is not false. Fixed in 46c19a2 :)