search

terrymun / paver

Paver, a panorama/image viewer replicating the effect seen in Facebook Pages app
MIT License
123 stars 38 forks source link

IE11 and Edge support #19

Closed taunoha closed 6 years ago

taunoha commented 7 years ago

Hello,

I wonder what could be the reason that Paver doesn't work in Internet Explorer 11 and Microsoft Edge?

terrymun commented 7 years ago

Personally I have yet to test for IE support. Can you check your browser console and tell me what it says?

taunoha commented 7 years ago

Thanks for the quick reply! No errors in console :( You can see my solution here: http://merko.ee/paepargi/en/location/ (the big panoram image) Maybe I'm missing something? :s

michaelkaaring commented 6 years ago

Hi @terrymun! Are you any closer in resolving this issue? To me it looks like paver is not rendering at all. No paver events are fired and the parent don't have any paver css classes.

michaelkaaring commented 6 years ago

Nor are there any error messages in the console

terrymun commented 6 years ago

@taunoha @michaelkaaring It seems like the issue comes from IE/Edge declaring that it supports DeviceOrientationEvent yet not feeding any gyroscopic data. This is not caught in initial testing, which only checks for aberrant behavior in Firefox: https://github.com/terrymun/paver/blob/v1.3.3/src/js/jquery.paver.js#L820

Removing this check will fix the issue.