search

terryworona / TWMessageBarManager

An iOS manager for presenting system-wide notifications via a dropdown message bar.
MIT License
1.77k stars 191 forks source link

Add the TW namespace and rename the Classes directory. #13

Closed adonoho closed 10 years ago

adonoho commented 10 years ago

As this class looks promising, I've added a proper namespace and moved the classes into a non-generic directory name.

squarefrog commented 10 years ago

I think the only issue with renaming the classes (which I agree with btw) is that a new podspec will need generating. Cocoapods forbid updating specs which break existing installations. See the cocoapods FAQ

Specifications can be updated only if they don't affect existing installations.
terryworona commented 10 years ago

Thanks for this PR. I had already started a namespace refactor some time ago. I just merged it in.

As far as cocoapods goes, I contacted them this morning, and the solution we arrived at was:

  1. MessageBarManager will remain and continue to support versions 1.0.0 and 1.1.0
  2. A new pod, named TWMessageBarManager was created and will support versions 1.2.0 and onwards.

I'm still waiting for them to pull in the change, but it shouldn't be too long: https://github.com/CocoaPods/Specs/pull/6141

adonoho commented 10 years ago

Please change the name of the Classes directory to TWMessageBarManager. That is important to us folks not using CocoaPods.