search

terryworona / TWMessageBarManager

An iOS manager for presenting system-wide notifications via a dropdown message bar.
MIT License
1.77k stars 191 forks source link

Add support for displaying message from the bottom of the screen. #47

Closed rcedwards closed 6 years ago

terryworona commented 10 years ago

Hey @rcedwards, great addition to the library.

I pulled your fork into a bottom branch; I did some very minor cleanup and externalized that yPosition calculation to a helper function.

You mind taking a look at why orientation changes are broken for bottom presentations? As soon as we resolve that, it can be pulled in.

rcedwards commented 10 years ago

Sure thing, I'll take a look.

rcedwards commented 10 years ago

@terryworona I got the offset updated for rotation changes and presentation. Portrait upside down is a little funny looking in the simulator but that may be related to how the status bar is handled since regular top presenting messages remain stuck in landscape on this rotation also. Take a look and let me know what you think.

rcedwards commented 10 years ago

hey @terryworona did you have a chance to take a look at this changes? Thanks

terryworona commented 10 years ago

@rcedwards workin on it! Been a bit busy. Sooooon.

rcedwards commented 10 years ago

@terryworona sure thing. not a problem.