search

terryworona / TWMessageBarManager

An iOS manager for presenting system-wide notifications via a dropdown message bar.
MIT License
1.77k stars 191 forks source link

Add verticalSpacer option #8

Closed sirvine closed 10 years ago

sirvine commented 10 years ago

This commit adds a configuration option to set the resting top position of the message. This option expects a CGFloat value (e.g., topLayoutGuide.length in iOS7+) and will default to the status bar’s height if no value is passed.

terryworona commented 10 years ago

Updated drawing methods are a good idea, thanks for this.

However, I'm confused as to why we need a top offset? The status bar's height is compatible across iOS 7 and below. Is there some use case I'm missing here?

sirvine commented 10 years ago

In my case, it was odd to have the messages appear below the status bar, but on top of the navigation bar. I prefer to have the top of the messages appear at the bottom of the navigation bar, at the so-called 'topLayoutGuide' in iOS7+.

terryworona commented 10 years ago

Fixed iOS 7 sizing methods in v1.1.0. Thanks for this.

As for the vertical spacer, I'd like to keep the layout as it currently is (top-most subview, directly under the status bar). I really don't want to get into alternative layout mechanism; keeping it simple for now.