search

terryyin / lizard

A simple code complexity analyser without caring about the C/C++ header files or Java imports, supports most of the popular languages.
Other
1.85k stars 250 forks source link

Structural fan_in _fan_out prototype #109

Closed mehrdad89 closed 8 years ago

mehrdad89 commented 8 years ago

Introducing structural fan_in and fan_out as an extension for Lizard. @terryyin, I also fixed the issue regarding basestring which is not compatible with python 3. Happy to contribute! (Tests will be added very soon)

terryyin commented 8 years ago

Let's wait for your tests.

mehrdad89 commented 8 years ago

Alright, they will be done as :soon: as possible. I have been busy these past days. Currently, I am celebrating our Persian new year. :bowtie: Hopefully, I can finish it tomorrow.

terryyin commented 8 years ago

Happy new year!

On 20 Mar 2016, at 9:09 PM, Mehrdad Meh notifications@github.com wrote:

Alright, they will be done as as possible. I have been busy these past days. Currently, I am celebrating our Persian new year.
Hopefully, I can finish it tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/terryyin/lizard/pull/109#issuecomment-198928203

mehrdad89 commented 8 years ago

Thank you @terryyin. tests were just included yesterday. Hope you find them helpful.

terryyin commented 8 years ago

Hi @mehrdad89 nice done:-)

I'm going to merge it now, so that to have the python3 fix. I've got a few improvement comments, would you care to do them?

mehrdad89 commented 8 years ago

Certainly, I would like to help. I'll fix them as much as I can, then send a pull request for you to review.