search

terryyin / lizard

A simple code complexity analyser without caring about the C/C++ header files or Java imports, supports most of the popular languages.
Other
1.85k stars 250 forks source link

Fix handling of constexpr in C++11 noexcept #147

Closed rakhimov closed 8 years ago

rakhimov commented 8 years ago

The constexpr inside of the noexcept is messing the parser as a function declaration parentheses.

This change is Reviewable

rakhimov commented 8 years ago

This is likely to have conflicts with #144 . I will rebase this PR after #144 gets merged to resolve the conflicts.

terryyin commented 8 years ago

Nice. I would put the different scenarios into separate tests. But I guess it doesn't matter much.

terryyin commented 8 years ago

Oops, there's a conflict. Can I improve the test a bit when I solve the conflict? Or you want to do it?

rakhimov commented 8 years ago

@terryyin I rebased the branch, but merge #144 first because there might be conflicts again. I will rebase again if that happens.

terryyin commented 8 years ago

Is this already included in another pull-request?

rakhimov commented 8 years ago

No, I will rebase this right now.

rakhimov commented 8 years ago

This is ready.