search

terryyin / lizard

A simple code complexity analyser without caring about the C/C++ header files or Java imports, supports most of the popular languages.
Other
1.85k stars 250 forks source link

Drop implementation for Nested Structure for Python (pylint does it better) #154

Closed rakhimov closed 7 years ago

rakhimov commented 8 years ago

I recently discovered that pylint has max-nested-blocks parameter, and it gets things right. (no issue with #141). I don't see any point in reinventing the wheel and wasting effort on this feature in Lizard. Let's drop the NS metric for Python. This is going to close #141 and #142.

Code-wise, there's nothing needs to change (maybe some warnings, like "Hey, use pylint for that!"). In the readme or theory, this note can be repeated.

rakhimov commented 7 years ago

This seems trivially implementable after all.

terryyin commented 7 years ago

Sorry for the late response. Travelling with family and w/o good network connection.

On 1 Jan 2017, at 2:36 PM, Olzhas Rakhimov notifications@github.com wrote:

This seems trivially implementable after all.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/terryyin/lizard/issues/154#issuecomment-269893792, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwJYmPrNsK4g8pnzqWXBbummOit2FDzks5rN0lpgaJpZM4KF8ZA.