search

terryyin / lizard

A simple code complexity analyser without caring about the C/C++ header files or Java imports, supports most of the popular languages.
Other
1.85k stars 250 forks source link

Fix unclosed file warning in auto_open #192

Closed feikou closed 7 years ago

feikou commented 7 years ago

Fix warning such as: lizard_ext/auto_open.py:31: ResourceWarning: unclosed file

feikou commented 7 years ago

Fixed auto_open test errors

feikou commented 7 years ago

@rakhimov sure, just squashed the commits together.

feikou commented 7 years ago

@rakhimov Would you merge this if you see fit? (I don't have write access) Please let me know if there is anything needs to be updated.

rakhimov commented 7 years ago

Sorry @amateurcoffee , it is up to @terryyin . I'm just helping him out. I believe this PR is good to go.

terryyin commented 7 years ago

Please allow me a couple of days. In a pretty heavy training process right now.

On 15 Aug 2017, at 3:58 AM, Olzhas Rakhimov notifications@github.com wrote:

Sorry @amateurcoffee https://github.com/amateurcoffee , it is up to @terryyin https://github.com/terryyin . I'm just helping him out. I believe this PR is good to go.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/terryyin/lizard/pull/192#issuecomment-322292737, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwJYovkKcT0s_d7LckFT4luwRMs99Urks5sYKbogaJpZM4Ot_mh.

feikou commented 7 years ago

@terryyin Sure

terryyin commented 7 years ago

Though about it a bit, don't know how to write some test for it still.

Thanks any way:-) @amateurcoffee