terryyin / lizard

A simple code complexity analyser without caring about the C/C++ header files or Java imports, supports most of the popular languages.
Other
1.85k stars 250 forks source link

Including coverage, extensions goto_count, statement_count and extended cvs output #300

Closed dutchedge closed 4 years ago

dutchedge commented 4 years ago

Hi,

I've got a new request for you. Included in this request are:

If you have any comments on my code please let me know.

One question: Is there a special reason why the tests use assertEqual instead of the assertRegex as stated by the DeprecationWarning?

dutchedge commented 4 years ago

Hi @terryyin,

The initial attempted had a lot of commits again :-). I squashed them to one for your convenience. If there are any other things I can do to make the merge easier. Please let me know.

Regards,

Patric

terryyin commented 4 years ago

Hi Patric,

thanks for the pull request. It looks cool. I'm surprised how simple the statement counter is. Perhaps I need a language filter for extensions.

A tiny comment is that if token == ";":... could be simplified as if token in [';', 'if',...].

I think using assertEqual is for historical reason. We need to gradually change them all.

thanks again:-)