Open bzgec opened 1 year ago
Hi @bzgec thanks for the pull request and sorry for the late response. Do you have test for "--short" option now?
Hi @bzgec thanks for the test. I have some comments on the test and solution. Some of them are preventive unless my assumptions are wrong.
print_and_save_modules
into save_modules
and save_modules
. But save_modules
seems to be a method that is blocking, rather than continuous yielding. The behaviour of lizard will be very different after this change.assertNotEqual
is something I will try my best to avoid. It's too easy to pass and too hard to fail, especially when you are asserting a very specific thing. I find the project so far has 0 assertNotEqual.
Add "--short" option prints only warnings and total summary.
Print warnings string:
!!!! Warnings (cyclomatic_complexity > 15 or length > 1000 or nloc > 1000000 or parameter_count > 100) !!!!
(problematic functions are not printed in red)No thresholds exceeded (cyclomatic_complexity > 15 or length > 1000 or nloc > 1000000 or parameter_count > 100)
Missing "--short" option tests