search

terryyin / lizard

A simple code complexity analyser without caring about the C/C++ header files or Java imports, supports most of the popular languages.
Other
1.85k stars 250 forks source link

Request: Ability to specify NLOC threshold #86

Closed pricemi115 closed 8 years ago

pricemi115 commented 8 years ago

Thank you for this tool :) I am using this to ensure our code meets the CCN & NLOC requirements of our coding standard. It would be nice if we could specify a threshold for NLOC like we can for CCN, To my team, NLOC is a better criterion than raw length. I took the liberty of modifying my local lizard.py (v1.9.22) to do this. See attached, lizard.py.txt

terryyin commented 8 years ago

Thanks @pricemi115 yes, I agree it's very useful. Do you want to make a proper "pull request"? by fork my repository and make the change then send pull request. By doing this you will be listed as the contributor for this part:-) Or you are fine that I just copy your code?

Reminder: if you send pull request, better also add enough test:-)

pricemi115 commented 8 years ago

If you copy the code that would be easier. The credit really belongs to you anyway. It was a pretty easy mod :)

Sent from my iPhone

On Jan 27, 2016, at 7:00 PM, Terry Yin notifications@github.com wrote:

Thanks @pricemi115 yes, I agree it's very useful. Do you want to make a proper "pull request"? by fork my repository and make the change then send pull request. By doing this you will be listed as the contributor for this part:-) Or you are fine that I just copy your code?

Reminder: if you send pull request, better also add enough test:-)

— Reply to this email directly or view it on GitHub.

terryyin commented 8 years ago

@pricemi115 In stead of add a new option N, I added a new option T.

lizard -Tnloc=10

will set the threshold for NLOC to be 10. A new release has been created, you can try now.

pricemi115 commented 8 years ago

Awesome!! We will try it out tomorrow or early next week. Thank you :)

On Jan 28, 2016, at 10:26 PM, Terry Yin notifications@github.com wrote:

@pricemi115 https://github.com/pricemi115 In stead of add a new option N, I added a new option T.

lizard -Tnloc=10

will set the threshold for NLOC to be 10. A new release has been created, you can try now.

— Reply to this email directly or view it on GitHub https://github.com/terryyin/lizard/issues/86#issuecomment-176551671.