terryzhao127 / tensorflow-windows-build-script

A script to automate building Tensorflow on Windows and solve some problems
GNU General Public License v3.0
102 stars 35 forks source link

Build ignores the symbols of tf_exported_symbols_msvc.lds #11

Closed subavicky closed 5 years ago

subavicky commented 5 years ago

Thanks for the Script. I am able to build the libtensorflow_cc.so, rename dll and lib and find the missing symbols. But when I try to add it to tf_exported_symbols_msvc.lds and build again, I am getting this error.

warning LNK4017: ?GetVarint32PtrFallback@core@tensorflow@@YAPEBDPEBD0PEAI@Z statement not supported for the target platform; ignored

StevenRoodhorst commented 5 years ago

Can you post the complete linker error that comes from your missing symbols? It could also have to do something with 32/64 bits difference. What is your VisualStudio project configuration?

terryzhao127 commented 5 years ago

Same as #3. You should build with x64 configuration in Visual Studio.

subavicky commented 5 years ago

I tried with all the four combinations of architecture(x64, x86) and the build type(Release, Debug). Every time I get the same error.

terryzhao127 commented 5 years ago

Do you mean you have tried to build TF without this symbol, but with all other missing symbols, and then you could not build successfully in VS?

subavicky commented 5 years ago

No. During my build in VS, I got only one linker error which says "undefined symbol ?GetVarint32PtrFallback@core@tensorflow@@YAPEBDPEBD0PEAI@Z".

When I tried to add this symbol to tf_exported_symbols_msvc.lds and build the tensorflow again using the script, I got the above warning which essentially says it is ignoring the symbol and building with it.

StevenRoodhorst commented 5 years ago

Are you sure you are building libtensorflow_cc.so and not libtensorflow.so?

terryzhao127 commented 5 years ago

Closed due to inactivity.