search

terryzhao127 / tensorflow-windows-build-script

A script to automate building Tensorflow on Windows and solve some problems
GNU General Public License v3.0
102 stars 35 forks source link

Test for C++ API of v1.13.1 #15

Closed terryzhao127 closed 5 years ago

terryzhao127 commented 5 years ago

The C++ API of v1.13.1 has not been tested.

terryzhao127 commented 5 years ago

@asbe @Steroes @kevinLu1114 @ihuale

Ok, the symbol patch for v1.13.1 is created at de2e3bba1cfe7e78b3283cbdbb5698551f8909a4 which needs testing.

terryzhao127 commented 5 years ago

@asbe @Steroes @kevinLu1114 @ihuale Anyone tested?

asbe commented 5 years ago

Seems to build correctly uncer VS2017, but I have to add more symbols to the patch to get my test code (simple matrix multiplication) to link. Still cycling through rebuilding dll, finding missing symbols, rebuilding etc. Any reason why we cannot use an EXP file as linker input instead?

terryzhao127 commented 5 years ago

So now added symbols work?

I don’t know what exp file is. What does it do?

asbe commented 5 years ago

@guikarist Can report success using DLL - but had to add more symbols. I now have a 35MB binary that does 2x2 matrix multiplication ;-)

The exp or export file should provide the symbols needed for linker, (https://docs.microsoft.com/en-us/cpp/build/reference/working-with-import-libraries-and-export-files?view=vs-2017) - but I don't understand why the code does not export those correctly in the first place. The export file for the .so can be found in the bazel-out directory of the build. But if I try to use it I get unicode issues.

terryzhao127 commented 5 years ago

So we can say v1.13.1 is tested.

Closed