search

terser / html-minifier-terser

actively maintained fork of html-minifier - minify HTML, CSS and JS code using terser - supports ES6 code
https://terser.org/html-minifier-terser
MIT License
376 stars 30 forks source link

Update clean-css version #65

Closed amerllica closed 3 years ago

amerllica commented 3 years ago

This PR will resolve #64

amerllica commented 3 years ago

@DanielRuf, Thanks for your review, I reverted all files except the package.json file.

DanielRuf commented 3 years ago

It seems some tests are failing. I will check these and will push the changed tests to this PR when I find some time.

amerllica commented 3 years ago

@DanielRuf, I checked, by the new version 5.1.3 some tests will be failed, but test work with the version 4.2.3. weird, I should check it. no worries.

DanielRuf commented 3 years ago

That's mostly because clean-css adds quotation marks for URLs by default (and maybe a few more changes).

If you want you can use and adapt the changes from https://github.com/kangax/html-minifier/pull/1098

amerllica commented 3 years ago

@DanielRuf, I learned from the given link but I fixed ours with my logic. please check it. thanks.

amerllica commented 3 years ago

@DanielRuf, this PR passed All checks.