search

tersiswilvin / Roblox-Legacy-Old-Theme

Repository for the Roblox Legacy Old Theme.
https://userstyles.world/style/5399/
12 stars 1 forks source link

Changes to fix accuracy #98

Open slimsgym opened 1 month ago

slimsgym commented 1 month ago

Type

Both

Describe the Feature

This is by far the best old Roblox extension, but some parts are somewhat inaccurate. Here is everything I suggest making it almost fully authentic, sorted based on how much they should be prioritized.

  1. 2019 is noticeably unauthentic. The text color was a lighter bit of black but is instead completely colorless, this is very noticeable and somewhat bothering. The text on the top bar looks really weird, which I will explain how to fix right now.
  2. Top bar is pretty inaccurate; the home page button didn't really exist for a while aside from the icon which took you there. Not only that, all of the text in the top bar is squished together and the search bar was closer to the right side, it really doesn't look like how it did in 2019-2016.
  3. Fake ads aren't that good, they only show Roblox related advertisements and aren't placed that good. I recommend ripping ads from the wayback machine to help with this.
  4. Lastly, an issue with the home page is it doesn't show what your friends are playing under their avatar icon, this seems pretty advanced to code, so I think it's the least important but would be nice, if possible, to add.

I will attach images of the actual (2018 and 2019L) home pages to give you more reference to go off of what I suggested.

Screenshot 2024-09-27 180252 image

tersiswilvin commented 1 month ago

1.) Roblox has always used #191919 as its base text color other than report labels and error labels that uses a red color (#d86868), and a few others that use a slightly lighter shade (usually #757575 or #b8b8b8) since around late 2014 to atleast mid 2015. 2.) There is no home button on the navigation topbar other than the roblox logo, unless you're using btroblox or another extension that adds that to the navigation itself. The navigation "squished" is how it's like for lower resolution monitor or devices, higher resolutions uses more width space. 3.) Sadly there is no way of pulling ads from the wayback machine using CSS, while I agree fake ads don't look as good as I wanted it to, the default roblox ad had to do as there is (as far as I am aware) no way of cycling between ad img urls using css unless I use an animation. 4.) Lastly, while the theme does initially show the game name on the peoples list, it can be removed with "Legacy Next Styleguide", I will consider adding an option to toggle peoples games names for more control.

slimsgym commented 1 month ago

Thanks for this info, I mostly wasn't aware and some things I would have never noticed without it being pointed out. I was in fact wrong about the first one, as it appears I simply do not remember how odd it looked in that period.

tersiswilvin commented 1 month ago

Thanks for this info, I mostly wasn't aware and some things I would have never noticed without it being pointed out. I was in fact wrong about the first one, as it appears I simply do not remember how odd it looked in that period.

No worries.

tersiswilvin commented 1 month ago

I will consider adding an option to toggle peoples games names for more control.

Added in commit https://github.com/tersiswilvin/Roblox-Legacy-Old-Theme/commit/7e0c2442e5928ab01c98708adeba0b471d7a052c