fix: remove use of deprecated UIWebView API - Githubissues

terveystalo / react-native-piwik-pro-sdk

React Native wrapper for Piwik Pro SDK

https://www.npmjs.com/package/react-native-piwik-pro-sdk

MIT License

2 stars 2 forks source link

fix: remove use of deprecated UIWebView API #36

Closed aeirola closed 3 years ago

aeirola commented 3 years ago

Fixes #28

aeirola commented 3 years ago

Version 1.0.6 deprecated the setCustomDimensionForIndex method (https://github.com/PiwikPRO/piwik-pro-sdk-framework-ios/compare/1.0.5...1.0.6#diff-896a60474d8f2d8b60a212d70d58f2d682b94c13d9fe2b59b077c3dcbdc43e16R421) which is used by this library.

Unfortunately the suggested alternative setCustomDimensionForID seems to work differently, adding the custom dimensions to all subsequent events as well. Additionally the new method isn't mentioned in the documentation https://developers.piwik.pro/en/latest/sdk/Piwik_PRO_SDK_for_iOS.html#tracking-with-custom-dimensions so sticking with using the deprecated method for now.