search

terwanerik / Retini

A super simple retina (2x, 3x) image converter.
http://terwanerik.github.io/Retini/
MIT License
200 stars 31 forks source link

Wrong @2x Conversion #2

Closed onursenture closed 8 years ago

onursenture commented 8 years ago

@2x outputs are bigger than @3x input file. Ex: I drop a 1125x80 pixel image with @3x suffix, Retini gives me a 1500x117 pixel @2x output.

terwanerik commented 8 years ago

Is it 72dpi or something else? I recently found a bug where 300dpi jpeg images weren't resized correctly, was going to look into that.

onursenture commented 8 years ago

Its 72 dpi png. https://www.dropbox.com/s/66yco5a8ywx24ir/Screenshot%202015-11-10%2018.42.56.png?dl=0

terwanerik commented 8 years ago

Alright thanks! I'm going to look into that.

onursenture commented 8 years ago

By the way @2x outputs are exactly double sized of the correct resolution.

terwanerik commented 8 years ago

Is there a way you can send the actual image this is happening with? I generated the exact same image (in size, dpi etc.) in PS, but it's resizing as it should.

onursenture commented 8 years ago

Sure. It might be related with my workflow because all the images I have been working on converted wrong.

switch_soundon 3x button_oyna 3x button_ayarlar 3x

onursenture commented 8 years ago

These files has @3x postfix by the way.

terwanerik commented 8 years ago

Alright, i tried 'm all, and they all resize just fine. I think when you uploaded it to the image server the server converted it to a proper PNG. Are you sure it's an actual PNG? Or a jpeg/tiff/psd with a PNG extension?

onursenture commented 8 years ago

Nop, I'm pretty sure that these are all proper pngs.

terwanerik commented 8 years ago

You mentioned that it might be because of your workflow, what is your workflow if i may aks? I still am unable to reproduce the problem.

terwanerik commented 8 years ago

Are you using a retina Mac? I just bought a retina MacBook, and noticed some weird problems. Going to look into this asap.

onursenture commented 8 years ago

Yes! I’m using retina Macbook.

On Fri, Dec 11, 2015 at 6:39 PM, Erik Terwan notifications@github.com wrote:

Are you using a retina Mac? I just bought a retina MacBook, and noticed some weird problems. Going to look into this asap.

Reply to this email directly or view it on GitHub: https://github.com/terwanerik/Retini/issues/2#issuecomment-163985719

terwanerik commented 8 years ago

Fixed this in version 1.0.8. Closing.

onursenture commented 8 years ago

Thanks! I'll try asap.

terwanerik commented 8 years ago

Just to be sure, it's working for you as well?

onursenture commented 8 years ago

I haven’t yet updated. We have started a project with buggy version, I’ll update Retini after we release the project. :)

Onur Şentüre / Product Designer  onur@orkestrayazilim.com / 05355021052

Orkestra Yazılım  R. Oğuz Arık Mah. Bestekar Sok. 62/8Çankaya, Ankara  http://orkestra.co

On Wed, Jan 13, 2016 at 10:21 PM, Erik Terwan notifications@github.com wrote:

Just to be sure, it's working for you as well?

Reply to this email directly or view it on GitHub: https://github.com/terwanerik/Retini/issues/2#issuecomment-171421592