tesYolan / AvatarOrchestrator

3 stars 2 forks source link

Need to run `npm install` before running `./build.sh`. #34

Open tesYolan opened 6 years ago

tesYolan commented 6 years ago

As it stands currently, one needs to run npm install in the local directory before one is capable of running the application via simple docker-compose up as it otherwise throws the following error:

node_1     | [0] [nodemon] 1.17.3
node_1     | [0] [nodemon] to restart at any time, enter `rs`
node_1     | [0] [nodemon] watching: *.*
node_1     | [0] [nodemon] starting `node app.js`
node_1     | [3] [12:56:41] Local gulp not found in ~/app/mediasoup-demo/app
node_1     | [3] [12:56:41] Try running: npm install gulp
node_1     | [3] npm ERR! code ELIFECYCLE
node_1     | [3] npm ERR! errno 1
node_1     | [3] npm ERR! rest_for_head@0.0.1 start-client: `cd mediasoup-demo/app && gulp live`
node_1     | [3] npm ERR! Exit status 1
node_1     | npm ERR! 
node_1     | [3] npm ERR! Failed at the rest_for_head@0.0.1 start-client script.

This is due to primarily https://github.com/tesYolan/Restforhead/blob/master/Dockerfile#L26
https://github.com/tesYolan/Restforhead/blob/master/docker-compose.yml#L10 and https://github.com/tesYolan/Restforhead/blob/master/docker-compose.yml#L11.

The later two were added to bypass the error stemming from installing pyzmq for the debian as they have different dependencies and thus throws library unknown if node_modules are mapped directly.

Anyways, there is a lot going on there and needs to be simplified as to avoid calling npm install as setting it up should take that much.

tesYolan commented 6 years ago

Similar to #33. Closes it.