search

tesis-dynaware / graph-editor

Eclipse Public License 1.0
132 stars 42 forks source link

Add GNodeSkin dispose method #20

Closed eckig closed 9 years ago

eckig commented 9 years ago

Please add a dispose method to the GNodeSkin class so we can do a proper cleanup when the skin is no longer used.

Maybe even retrofit the class to implements the Skin interface? (https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/Skin.html)

rmfisher commented 9 years ago

I added a dispose method to all skin classes. It's called on the skin after it's JavaFX node is removed from the view.

I can't implement the Skin interface, as the model classes like GNode aren't Skinnable.

eckig commented 9 years ago

Regarding the Skin interface: I realized it a few moments after I openened this issue. Just came to my mind, because they are quite similar.

But thanks again for implementing it on such a short notice ;-)