search

tesla-local-control / tesla-local-control-addon

Control your Tesla locally from HomeAssistant
Apache License 2.0
10 stars 2 forks source link

No retry logic => Unable to connect (Lookup error) etc #29

Open baylanger opened 1 week ago

baylanger commented 1 week ago

Upgrded the network switch and noticed the container went dead.

mosquitto_sub failed to connect to MQTT:

Unable to connect (Lookup error.

Should we make this better? Implement t there be some logic to retry X times when there's a DNS or network issue?

raphmur commented 1 week ago

Indeed... Restarting the addon solved the issue? Btw there is a "watchdog" option, which so far did not have any effect for me, meaning not restarting after crash

baylanger commented 1 week ago

Yes restarting did it. I don't have WatchDog enable but can take a look why it fails to restart at all on failure if WD is enable.

iainbullock commented 1 week ago

Is there an equivilant of the docker-compose.yml restart: unless-stopped option? Would this achieve what you are suggesting? Also have set -e during the shell scripts except where we are specifically looking for the exit status value should catch other failures and cause a restart of the container

raphmur commented 1 week ago

I think we went quite aggressive with the set +e This might be an issue indeed