search

tesla-local-control / tesla_ble_mqtt_core

Core content for the tesla_ble tools
Apache License 2.0
3 stars 2 forks source link

Add shell-fmt to pre-commit CI #59

Closed epenet closed 4 months ago

baylanger commented 4 months ago

@epenet I was slowly modding everything with 2 indent but you did the hard work!

Not sure for my colleagues but personally, I wasn't aware such hooks existed.

Minutes ago I made changes to the pre commit/push, will push to this branch.

There are conflicts, will try to fix them and merge this asap.

Thank you!

baylanger commented 4 months ago

I noticed you also changed logging level for some messages, it was on my mind to go over all of them and readjust them. Thank you to be ahead ;)

baylanger commented 4 months ago

Will manage this one in another PR.

In subroutines.sh line 15:
    tesla_ctrl_out=$(tesla-control -vin $vin -ble -key-name /share/tesla_blemqtt/${vin}_private.pem -key-file /share/tesla_ble_mqtt/${vin}_private.pem $@ 2>&1)
    ^-- SC2068: Double quote array expansions to avoid re-splitting elements.
epenet commented 4 months ago

I noticed you also changed logging level for some messages, it was on my mind to go over all of them and readjust them. Thank you to be ahead ;)

I'm not sure what you mean... I didn't change any logging levels

baylanger commented 4 months ago

No worry; I am having my coffee... I recall seeing a PR we merged likely after you branch from main... a colleague made those changes. Turns out I reverted his changes 🤔 but I'm not sure why he first changed cuz what I thought we changed look perfectly fine to me 😄 Will sync-up with him.