search

tesla-local-control / tesla_ble_mqtt_docker

Apache License 2.0
29 stars 8 forks source link

Minor fixes iain-dev->main #33

Closed iainbullock closed 3 months ago

iainbullock commented 3 months ago

Fix spelling in Dockerfile Remove Buy me a Coffee Button from README.md

baylanger commented 3 months ago

The last thing to do before approving, need to have app/ use _core main branch. Currently the commit comes from stage.

iainbullock commented 3 months ago

Agreed. Leave it me to figure out how to do this. I need to be able to do it as it will be a regular thing to do

raphmur commented 3 months ago

Are you pulling latest core before pushing this one? We'll need to merge PR 69 in _core before. It will solve https://github.com/tesla-local-control/tesla_ble_mqtt_docker/issues/31

iainbullock commented 3 months ago

Yes I need to do this:

As per WhatsApp: We still need to 1. update the Install.md 2. switch from stage to main branch 3. copy over the changelog from core

I will pull in latest _core

baylanger commented 3 months ago

Lets get rid of all the TODO comments as well unless we still need any?!

iainbullock commented 3 months ago

Lets get rid of all the TODO comments as well unless we still need any?!

Done in #iain-dev

iainbullock commented 3 months ago

@baylanger @epenet thanks for your comments. Here are my thoughts:

I think 'close' is ok for these instructions, especially as we can't (yet?) quantify it. I think maybe we should have a 'hardware' page where we can detail this as our experience grows. E.g. what devices work best (or don't work), real world range and reliability based on experience, recommended good practice e.g. don't use 2.4GHz wifi, use USB extension leads etc

Capitalisation of Docker - will do

docker-compose versus docker compose. Great comments. I will investigate and if it works use docker compose updating the document accordingly. I broke my setup yesterday when installing docker-compose when it probably isn't needed. If I can break my system, we can be sure less experienced people will, so if an installation can be avoid then that's definately the best way

curl instead of wget. No problem

Formatting markup - I just used whatever the OP used. I think the ```yaml provides a copy to clipboard button, so is useful for code snippets

I will update tonight. As per WhatsApp also have to fix the 404 on the app -> xxxx link

iainbullock commented 3 months ago

I am deleting the iain-dev branch and recreating it in order to fix the 404 error. This PR will have to close. I'll open a new PR when it's done