search

tesla / m2eclipse-tycho

25 stars 26 forks source link

Fix disappearing classpath entries on project update #12

Closed fbricon closed 11 years ago

fbricon commented 11 years ago

The new test case couldn't reproduce the issue, but at least can serve as a non-regression test for the future. New implementation works anyway (smoke tested) and all existing tests pass.

Also bumped tycho version to 0.18.1

ifedorenko commented 11 years ago

I need to use this patch for some time to make sure it does not cause any unwanted side effects.

jsievers commented 11 years ago

tested and works for me with the tycho surefire bundles which use surefire jars as nested jars http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/tycho-surefire

with patch applied, I no longer get errors during Maven > Update Project.

Thanks Fred!

ifedorenko commented 11 years ago

I had some odd issues with "normal" projects. While working on m2e maven-3.1.0 branch, PDE wouldn't always propagate changes in maven-bundle-plugin projects to Tycho projects and I had to do some random actions (update dependencies, clean build, update classpath, the infamous pde dance, in other words) to get PDE do recognize the changes. I am not sure if new version is m2e-tycho is really to blame, but this change does not address the root cause -- race condition somewhere inside PDE -- and I'd really hate to trade annoying but obvious problem with nested jars for a problem that is much more obscure and thus harder to troubleshoot. I suggest we use this code at least a week before we decide.

ifedorenko commented 11 years ago

pushed to master, but github isn't smart enough to autoclose pull requests. boo.