search

tesla / m2eclipse-tycho

25 stars 26 forks source link

Added error markers for maven-bundle-plugins with duplicated goals #20

Closed gamerson closed 10 years ago

gamerson commented 10 years ago

Added error markers if there are multiple executions found. Also added simplified unit test to check for error markers.

ifedorenko commented 10 years ago

Apart from a couple of minor/trivial comments, looks good.

Have you signed the CLA? http://takari.io/support/takaricla.pdf

gamerson commented 10 years ago

I have not signed that CLA to my knowledge, once I sign it where should I send it?

On Tue, Jul 29, 2014 at 2:52 PM, ifedorenko notifications@github.com wrote:

Apart from a couple of minor/trivial comments, looks good.

Have you signed the CLA? http://takari.io/support/takaricla.pdf

— Reply to this email directly or view it on GitHub https://github.com/tesla/m2eclipse-tycho/pull/20#issuecomment-50441688.

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

ifedorenko commented 10 years ago

This is explained in the form. The easiest is probably to scan and email it to team@takari.io . There is also a fax number, but something tells me finding a working fax machine may be tricky :-)

gamerson commented 10 years ago

Signed, scanned and sent to that email address.

gamerson commented 10 years ago

Just forced pushed new commit.

gamerson commented 10 years ago

What needs to happen in order for this fix to make it into the m2e connector discovery version of the Tycho connector?

ifedorenko commented 10 years ago

Not sure. I gave up trying to maintain discovery catalog long time ago. Ask on m2e-dev mailing list.

jvanzyl commented 10 years ago

I will update it this weekend.