teslamate-org / teslamate

A self-hosted data logger for your Tesla 🚘
https://docs.teslamate.org
MIT License
6.01k stars 749 forks source link

Website Autobuild stopped working #3512

Closed JakobLichterfeld closed 11 months ago

JakobLichterfeld commented 11 months ago

The automatic deployment to https://docs.teslamate.org/ stopped working since renaming to teslamate-org.

2845 and #3472 are not visible on Website.

Org name change is reflected correctly in docusaurus config: https://github.com/teslamate-org/teslamate/blob/008955ab18c07be2a88218ff77423444e07aa5bd/website/docusaurus.config.js#L7

JakobLichterfeld commented 11 months ago

Deployment config seems to be incorrect. I do not have edit rights there. @cwanja can you adjust it?

cwanja commented 11 months ago

I do not have any elevated access beyond what is in the GitHub repo. When you say "deployment config", where are you referring to @JakobLichterfeld?

Is there a server side config located at docs.teslamate.org? @adriankumpf

JakobLichterfeld commented 11 months ago

I do not have any elevated access beyond what is in the GitHub repo. When you say "deployment config", where are you referring to @JakobLichterfeld? Sorry, this one: https://github.com/teslamate-org/teslamate/deployments image

cwanja commented 11 months ago

I do not have any elevated access beyond what is in the GitHub repo. When you say "deployment config", where are you referring to @JakobLichterfeld? Sorry, this one: https://github.com/teslamate-org/teslamate/deployments image

I can get to the Deployment page, but I cannot get into the the github.io link from your image. There is a "Manage Environments" link, but not seeing where to configure it. Happy to jump on a Teams call to screenshare. Though I believe our permissions are the same for the GitHub repo.

JakobLichterfeld commented 11 months ago

Though I believe our permissions are the same for the GitHub repo.

No, I do not have the "Manage Environments", as I'm a Member and you are configured as owner in the teslamate-org, see https://github.com/orgs/teslamate-org/people

Anyway, I didn't use the deployment for docu build before, so need to look into it

cwanja commented 11 months ago

No, I do not have the "Manage Environments", as I'm a Member and you are configured as owner in the teslamate-org, see https://github.com/orgs/teslamate-org/people

Yikes. News to me. We probably need a second, as I know Adrian step away. I do not want to be a single bottle neck.

Clicking through the Manage Environments, I cannot see anything "wrong". But will keep diving into it.

cwanja commented 11 months ago

That "environment settings" looks like GitHub pages - which is the adrian link in your image that is a 404. Is your assumption that GitHub pages deploys to Docusaurus?

Also, assuming Adrian's owns docs.teslamate.org (@adriankumpf) and not sure if something has to be updated there.

DrMichael commented 11 months ago

Yikes. News to me. We probably need a second, as I know Adrian step away. I do not want to be a single bottle neck.

Perhaps you can promote @JakobLichterfeld to owner?

cwanja commented 11 months ago

Yikes. News to me. We probably need a second, as I know Adrian step away. I do not want to be a single bottle neck.

Perhaps you can promote @JakobLichterfeld to owner?

Done. Welcome to the club @JakobLichterfeld 😄

JakobLichterfeld commented 11 months ago

s your assumption that GitHub pages deploys to Docusaurus?

In the readme it is stated that: https://github.com/teslamate-org/teslamate/blob/008955ab18c07be2a88218ff77423444e07aa5bd/website/README.md?plain=1#L3

But I can't find any other reference than in the docusaurus.config: https://github.com/teslamate-org/teslamate/blob/008955ab18c07be2a88218ff77423444e07aa5bd/website/docusaurus.config.js#L4

I assumed the GitHub Pages Deployment is the deployment for the website, yes.

JakobLichterfeld commented 11 months ago

And our new org does not have the the teslamate docu website as verified domain, thus we can't deploy there, see: https://github.com/organizations/teslamate-org/settings/pages

And we can't add docs.teslamate.org, as it is alredy added in Adrians personal account

cwanja commented 11 months ago

@adriankumpf - we will need you to add the necessary DNS entries. I just added http://docs.teslamate.org as a domain. My guess is the TXT records for the domain from when TeslaMate was under Adrian's account will not work.

adriankumpf commented 11 months ago

@cwanja @JakobLichterfeld The docs are actually hosted on Netlify, not GitHub pages. I've updated the site configuration and it should work again. Unfortunately, the non-pro plan does not allow adding more members to the team on Netlify, so I cannot invite you. The config usually does not need to be changed, though, since every commit gets deployed automatically. If you ever want to make changes, I'll be around.

brianmay commented 11 months ago

I think, like it or not, we really need control over the teslamate.org domain. That way we still have options if Netlify stops meeting our needs and we cannot contact Adrian.

Disregard if we already do have control, e.g. via Netlify.

The website has <title>Import from tesla-apiscraper (BETA) | TeslaMate</title> - perhaps this could be changed?

And would also be good if the website has some sort of date stamp - at least I can't see any - so we can easily tell if it is up-to-date or not.

parkr commented 11 months ago

I'd recommend some setup with octodns and a repo for this like http://GitHub.com/jekyll/dns. DNS is declaratively defined, synced with GitHub actions, and is version controlled. This democratizes access to the domain without requiring handing out credentials or managing more things outside GitHub.

cwanja commented 11 months ago

Resolved based upon Adrian's comment.

Open to suggestions in a discussion for management of the domain from Brian and Parker.

JakobLichterfeld commented 11 months ago

Deployment works as expected, checks are running and even a nice preview is build before the merge, see https://github.com/teslamate-org/teslamate/pull/3344