search

teslamate-org / teslamate

A self-hosted data logger for your Tesla 🚘
https://docs.teslamate.org
MIT License
6.05k stars 755 forks source link

feat: Update Grafana to 11.3.1 #4299

Open swiffer opened 1 month ago

swiffer commented 1 month ago

Upgrades Grafana to 11.3.1. Grafana switched to scenes powered dashboards for which the experimental setting date_formats.use_browser_locale is breaking timerange selector & urls containing absolute time ranges.

Therefore date_formats.use_browser_locale has been temporarily disabled (see comment in Dockerfile).

Tracking issue: https://github.com/grafana/grafana/issues/95209

netlify[bot] commented 1 month ago

Deploy Preview for teslamate ready!

Name Link
Latest commit 90ee683b72fdc625f8d5216ec1f7ca9bec0bb944
Latest deploy log https://app.netlify.com/sites/teslamate/deploys/6745a8fc448c0a0008d6ccd0
Deploy Preview https://deploy-preview-4299--teslamate.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cwanja commented 1 month ago

The Dutch Tax dashboard is broken - has that been the case before, looks really outdated?

Works currently in 1.30.1. Imagine that is a side effect from Grafana 11.3.

swiffer commented 1 month ago

The Dutch Tax dashboard is broken - has that been the case before, looks really outdated?

Works currently in 1.30.1. Imagine that is a side effect from Grafana 11.3.

yes but for me it shows two rows with two tables each (two cars). i think that was not the intention. anyway, opened it in the current grafana image, fixed the markup, exported and imported again, working now!

swiffer commented 3 weeks ago

@JakobLichterfeld - i would prefer getting this merged with the temp fixes to stay up 2 date (and for me getting this branch integrated to stop keeping it up 2 date). there shouldn't be any regressions now. see comments for specific changes done.

swiffer commented 3 weeks ago

😞 back to draft, featue toggles currently cannot be disabled by env vars:

https://github.com/grafana/grafana/pull/90178/files

JakobLichterfeld commented 3 weeks ago

back to draft, featue toggles currently cannot be disabled by env vars:

Damm, was about to start testing right now

swiffer commented 3 days ago

@JakobLichterfeld - figured out what was causing the links between dashboards no longer working correctly.

it's caused by an experimental config setting. updated the PR description as well as the grafana tracking issue and disabled the setting in the dockerfile (adding a comment there as well).

with most of the dashboard work beeing done in #4338 this one is a simple version bump to grafana 11.3.1 (latest). as recommended this is the first patch release of 11.3.0.

the next bump will most likely happen 28th of january (11.4.1) if everything goes as planned: https://grafana.com/docs/grafana/latest/upgrade-guide/when-to-upgrade/#when-to-expect-releases

swiffer commented 17 hours ago

(not stressing!) - ready to be merged, don't know if that was clear from my last comment.

JakobLichterfeld commented 15 hours ago

(not stressing!) - ready to be merged,

Thanks for reminder.

don't know if that was clear from my last comment.

In fact, it was not clear to me if we could merge this without the other PR related to Grafana 11.3, which I either confused or no longer exists.

swiffer commented 14 hours ago

You remember correctly - most of the work of the previous 11.3 PR was included in #4338 - i reused this one for the simple bump to 11.3.1. the only remaining regression i noticed has been mitigated (dashboard links not working with the experimental config setting i described above).