search

teslamate-org / teslamate

A self-hosted data logger for your Tesla 🚘
https://docs.teslamate.org
MIT License
6.04k stars 752 forks source link

"Range Added" has incorrect units on the Charges dashboard #4348

Closed JakobLichterfeld closed 2 weeks ago

JakobLichterfeld commented 2 weeks ago

Hello, I'm a new user in this exact issue is something that bothered me enough to come here and search for answers. Was this issue corrected yet? I'm see the same behavior as op.

In the "range added" column, I would expect to see the number of miles that I gained during the charging session. Instead, it shows me how fast the charging occurred. This is super misleading because if I charged for 28 min and gained 20 miles of range, it displays 45 mph. If I was charged for exactly one hour, then that value would be accurate but I'd argue that most people are not charging for exactly one hour, and would rather see the number of miles worth of change during the amount of time they were plugged in and not for one hour.

Can this please be corrected or can there be an option to display the actual range added?

Originally posted by @1920x1200 in https://github.com/teslamate-org/teslamate/issues/4087#issuecomment-2453285969

JakobLichterfeld commented 2 weeks ago

@1920x1200 welcome to TeslaMate, nice to have you.

Please do not report an issue in a closed issue, it was only by accident I had notifications on for the closed issue.

Regarding the issue. @DrMichael solved it by renaming it to Range added / h, but @jheredianet accidentally reverted it when adding the Summary in #4144.

@swiffer What's your opinion on this? I personally do not see any benefit in Range added / h at all, but some do and would like to add it to MQTT as well #4130

swiffer commented 2 weeks ago

I think it's the unit Tesla is showing during Super Charging as well on screen, don't they. I would therefore say let's keep it like that.

see here, down on bottom of video, KPI in the middle: https://www.tesla.com/fr_ch/blog/introducing-v3-supercharging

At this rate, a Model 3 Long Range operating at peak efficiency can recover up to 75 miles of charge in 5 minutes and charge at rates of up to 1,000 miles per hour.

So therefore, rename the column to "Charge Rate (avg)" instead of "Range added" ?

JakobLichterfeld commented 2 weeks ago

I think it's the unit Tesla is showing during Super Charging as well on screen, don't they. I would therefore say let's keep it like that.

Yeah it is.

So therefore, rename the column to "Charge Rate (avg)" instead of "Range added" ?

I do like it. A better name than range added / h

swiffer commented 2 weeks ago

Ok, PR open in a sec ;)

swiffer commented 2 weeks ago

I wonder if we should replace Driven (km) and Odometer (km) by Range added instead. Are those 2 really helping here?

JakobLichterfeld commented 2 weeks ago

I wonder if we should replace Driven (km) and Odometer (km) by Range added instead. Are those 2 really helping here?

Odometer was recently added due to community request: https://github.com/teslamate-org/teslamate/discussions/4109#discussioncomment-10201456

I personally do not care about range added as I use added kWh

swiffer commented 2 weeks ago

still voting to replace Driven with Range added then, Driven is hard to grasp as it is not really related to the charge

JakobLichterfeld commented 2 weeks ago

Agree, what do you think @DrMichael ?

DrMichael commented 2 weeks ago

So therefore, rename the column to "Charge Rate (avg)" instead of "Range added" ?

Appears clearer. We could also name the column just "km /hr" and "mi / hr". (When looking at the screenshot.

DrMichael commented 2 weeks ago

still voting to replace Driven with Range added then, Driven is hard to grasp as it is not really related to the charge

Aren't that different things? Driven means distance driven since last charge, right?

I think, Odometer is fine. But yes, Driven and Odometer cover the same issue.

swiffer commented 2 weeks ago

still voting to replace Driven with Range added then, Driven is hard to grasp as it is not really related to the charge

Aren't that different things? Driven means distance driven since last charge, right?

Yes, different things, I myself finding driven not really helpful in context of charges, that's why I wanted to replace it.

I think, Odometer is fine. But yes, Driven and Odometer cover the same issue.

1920x1200 commented 2 weeks ago

If we're going to keep the speed of charging (in MPH), is there a way to add a column for the number of miles added during a charging session? Personally, I would find that more useful.

swiffer commented 2 weeks ago

That's what I suggested - will open a PR later

1920x1200 commented 2 hours ago

Thank you for fixing this in the latest update!