Show full VIN in dashboards when no car-name set at all - Githubissues

teslamate-org / teslamate

A self-hosted data logger for your Tesla 🚘

https://docs.teslamate.org

MIT License

6.05k stars 755 forks source link

Show full VIN in dashboards when no car-name set at all #4353

Closed swiffer closed 2 weeks ago

swiffer commented 3 weeks ago

          Hi everyone,

I had previously opened this pull request, for cases of unnamed vehicles

https://github.com/teslamate-org/teslamate/pull/4198

Looks like the behavior changed in this pull request

From:

To:

In my opinion, displaying a bunch of numbers with no context isn't too great.

Would you be opposed if I opened a new pull request to change back the case of unnamed vehicles to VIN $full_vin?

In summary:

Uniquely named vehicles: $Name
Duplicate named vehicles: $Name - $Last_six_of_vin
Unnamed vehicles: VIN $Full_vin

c.c. @swiffer , @JakobLichterfeld , @edgararroyo

Originally posted by @arcastro in https://github.com/teslamate-org/teslamate/issues/4230#issuecomment-2453862453

arcastro commented 2 weeks ago

Thank you both @swiffer and @JakobLichterfeld 👍👍