search

teslamate-org / teslamate

A self-hosted data logger for your Tesla 🚘
https://docs.teslamate.org
MIT License
6.04k stars 752 forks source link

feat: add Detailed Energy Use to drive-details #4386

Closed jameskitt616 closed 4 days ago

jameskitt616 commented 1 week ago

Add Detailed Energy Use to Drive Details to fix #4375. image

@swiffer ping

netlify[bot] commented 1 week ago

Deploy Preview for teslamate ready!

Name Link
Latest commit 59973f790f08c65025d9dc3b44f4d392d2f2e923
Latest deploy log https://app.netlify.com/sites/teslamate/deploys/673b776a3da2270008fbed8b
Deploy Preview https://deploy-preview-4386--teslamate.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

swiffer commented 1 week ago

Thanks for opening this PR - I do prefer getting #4367 in first.

This PR seems to be based on Grafana build bundled with TeslaMate v1.31.1, exports should be done on top of the latest master to avoid overwriting other changes / reduce noise from changed Grafana schema version.

To the added stats - as numbers are not fully matching and 10.6 kwh & 12.4 kwh are both referred to as "used" I would prefer changing that to Energy recovered and stop showing energy used before regenerative breaking. As the metric is new I've added a small explanation as well.

grafik

Commit that can be used after #4367 has been merged: https://github.com/teslamate-org/teslamate/commit/1b21cbb9f0b9eb102511521a4c81b1348f58785d - feel free to use it for updating your PR if you agree.

jameskitt616 commented 6 days ago

I copied your Updated file into the PR now.

cschanzle commented 6 days ago

Please use "braking" instead of "breaking".

JakobLichterfeld commented 5 days ago

I do prefer getting #4367 in first.

4367 is merged

swiffer commented 5 days ago

@jameskitt616 - could you reset this branch to lastest master and include commit f71c965fb1b97152ce607249bb871f7742b24277

(already including the change from "breaking" to "braking").

jameskitt616 commented 5 days ago

Resolved the conflicts

swiffer commented 5 days ago

Thank you, would have been better to do a rebase instead to keep commits history clean but i think @JakobLichterfeld will do a squash merge anyhow.

JakobLichterfeld commented 4 days ago

but i think @JakobLichterfeld will do a squash merge anyhow.

In most cases yes. In #4367 it was by mistake.

swiffer commented 4 days ago

ready for merge with squash