teslamate-org / teslamate

A self-hosted data logger for your Tesla 🚘
https://docs.teslamate.org
MIT License
6.07k stars 755 forks source link

Default geo-fences seem to small #833

Closed kimma closed 4 years ago

kimma commented 4 years ago

Describe the bug

The Geo Fences for known charging locations seems to be too small. Ex. charging on the "edge" superchargers of a Tesla Supercharger will not be registered as a Tesla Supercharger but instead the nearest street address.

Expected behavior

When TeslaMate registers a charging session it should always register to the nearest charging location even if it is not registered inside the geo fence (with of course an acceptable max-distance, ex. 300m or something).

How to reproduce it (as minimally and precisely as possible):

  1. Go to tesla supercharger
  2. Charge at the very edge of the supercharger (as far away as possible from the center according to the map)
  3. Observe that the charging session will be linked to the nearest street address instead of the supercharger itself

Screenshots

Charging at edge of Tesla Supercharger. Note the Street Address instead of correctly identified Tesla Charger image

Charging in the center of Tesla Supercharger. Note the correctly identified Tesla Supercharger. image

Environment

adriankumpf commented 4 years ago

The thing is, there are no default geo-fences. The location data comes from OpenStreetMap. So if a charger was not correctly detected, the intended solution is to create a geo-fence yourself e.g. in your case "Tesla Rugtvedt Supercharger" (Or consider contributing to OSM :) -> https://www.openstreetmap.org/node/7004520227#map=19/59.03748/9.67440)

kimma commented 4 years ago

Would it be possible to utilize https://openchargemap.org/ to map charges to a nearby charger instead of letting OpenStreetMap automatically try to match you with the closest POI (which often could turn out to not be a charger)?

It would probably be beneficial to also use this to automatically match the charger to a vendor, and allow users to manually set the charging cost not only on specific locations, but also on specific vendors.

kimma commented 4 years ago

Would it be possible to utilize https://openchargemap.org/ to map charges to a nearby charger instead of letting OpenStreetMap automatically try to match you with the closest POI (which often could turn out to not be a charger)?

https://openchargemap.org/site/develop/api#POI

distance | return results based on specified distance from specified latitude/longitude distanceunit | Miles or KM | Miles

distance return results based on specified distance from specified latitude/longitude (blank)
distanceunit Miles or KM Miles
stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.