Fix HTTP panic caused by nil pointer exception from a missing remote hash

teslamotors / ansible_puller

Ansible daemon for massively-scaleable Ansible

MIT License

125 stars 33 forks source link

Fix HTTP panic caused by nil pointer exception from a missing remote hash #20

Open scottcrossen opened 3 years ago

scottcrossen commented 3 years ago

This was the original intent and is included in the s3Downloader implementation of this interface

jyates commented 3 years ago

Agree that this matches the implementation in s3 downloader. Would it be possible to add some tests around this? At the very least some documentation on the interface would be nice so we know expected behavior

scottcrossen commented 3 years ago

Tests added

jyates commented 3 years ago

And some docs on the downloader interface please?