search

teslamotors / light-show

Tesla Light Show
3.24k stars 392 forks source link

feat: Add Node.js validator #19

Closed xsorifc28 closed 2 years ago

xsorifc28 commented 2 years ago

I built an online validator for the non-programming oriented, available here

Wanted to share the npm package as well: https://www.npmjs.com/package/@xsor/tlsv npm source: https://github.com/xsorifc28/tlsv website source: https://github.com/xsorifc28/vue-tlsv

Thanks for looking!

bendudz commented 2 years ago

This is a nice addition.

However, when memory size is over 1 (100% of 681 commands) the Python validator exits with an error, but the Node version says its valid.

{ "valid": true, "file": { "name": "lightshow.fseq", "size": 148612, "md5": "3fcc54c82f2f8714ba834dd747b3833c" }, "validation": { "frameCount": 3093, "stepTime": 50, "durationSecs": 154.65, "memoryUsage": "174.16" } } lightshow.zip

xsorifc28 commented 2 years ago

This is a nice addition.

However, when memory size is over 1 (100% of 681 commands) the Python validator exits with an error, but the Node version says its valid.

{ "valid": true, "file": { "name": "lightshow.fseq", "size": 148612, "md5": "3fcc54c82f2f8714ba834dd747b3833c" }, "validation": { "frameCount": 3093, "stepTime": 50, "durationSecs": 154.65, "memoryUsage": "174.16" } } lightshow.zip

Thank you for testing, will add a fix.