teslamotors / react-native-camera-kit

A high performance, easy to use, rock solid camera library for React Native apps.
MIT License
2.42k stars 577 forks source link

added code format to see type of code scanned #633

Closed android-imdad closed 1 month ago

android-imdad commented 6 months ago

Summary

Added codeFormat to see what kind of code is being scanned, useful when there is code specific validation that needs to be done.

How did you test this change?

Tested example apps on both IOS and Android, no visual change for screenshot.

android-imdad commented 6 months ago

Hi, yes will check these comments in a few days

android-imdad commented 4 months ago

@DavidBertet I fixed the indentation, accepted your changes and added types. Please review and let me know if there are any concerns.

DavidBertet commented 4 months ago

@DavidBertet I fixed the indentation, accepted your changes and added types. Please review and let me know if there are any concerns.

Thanks @android-imdad. Have you tried it? I doubt the iOS part compiles at all.

When I said to replace AVMetadataObject.ObjectType by CodeFormat, there is more than just changing a type. It has to be reflected all along the chain. On both camera & simulator, as well as in CameraProtocol

android-imdad commented 4 months ago

@DavidBertet I fixed the indentation, accepted your changes and added types. Please review and let me know if there are any concerns.

Thanks @android-imdad. Have you tried it? I doubt the iOS part compiles at all.

When I said to replace AVMetadataObject.ObjectType by CodeFormat, there is more than just changing a type. It has to be reflected all along the chain. On both camera & simulator, as well as in CameraProtocol

My bad, nope didn't try it after the change. Will test it and do a commit with the fixes.

android-imdad commented 4 months ago

@DavidBertet Please check now, I made the changes and tested in both IOS and Android, seems to be working as expected.

scarlac commented 1 month ago

Thanks @android-imdad and @DavidBertet !