search

teslamotors / vehicle-command

Apache License 2.0
436 stars 101 forks source link

CLOSURE_MOVE_TYPE_OPEN & CLOSURE_MOVE_TYPE_CLOSE don't work in trunk requests #110

Open itsMeDavidV opened 10 months ago

itsMeDavidV commented 10 months ago

CLOSURE_MOVE_TYPE_OPEN & CLOSURE_MOVE_TYPE_CLOSE requests for trunk return 503 like in issue #56, however unlike in that issue, the trunk does not move at all.

CLOSURE_MOVE_TYPE_OPEN & CLOSURE_MOVE_TYPE_CLOSE are needed, bc using CLOSURE_MOVE_TYPE_MOVE isn't always ideal, especially when the trunk is halfway open/closed, depending on the user's perspective. It would be counter intuitive to not let them chose a direction in that case.

sethterashima commented 10 months ago

Can you test against https://github.com/teslamotors/vehicle-command/pull/108/files?

Note the documentation changes on OpenTrunk/CloseTrunk/MoveTrunk; some cars lack the hardware for powered open (as opposed to unlatch) and close.

itsMeDavidV commented 10 months ago

Hi @sethterashima sorry I should note that I wasn't using the SDK when this error occurred, I called signed_command directly.

I also reproduced the exact same behavior on your branch just now as well as on the v0.0.2 release.

OpenTrunk() & CloseTrunk() don't open/close trunk and 503 is returned.

Should also note, when using the SDK, I don't have the proxy set up rn, so I just called said commands directly, so wasn't able to test automatic retires that proxy would implement. Manual retries don't have any effect on outcome.

some cars lack the hardware for powered open (as opposed to unlatch) and close.

Tested on M3 21 so can confirm the vehicle does have open/close actuation hardware & sw capability