search

teslamotors / vehicle-command

Apache License 2.0
428 stars 93 forks source link

Feature request: Allow "charging_manager" role to use "wake" and "charge-port-open" via BLE #232

Open erikgieseler opened 5 months ago

erikgieseler commented 5 months ago

I have just tried out the "charging_manager" role: The commands: charging-start, charging-stop and charging-set-amps work without any problems via BLE.

Unfortunately, the following commands do not work via BLE: wake and charge-port-open.

The following error messages are displayed: wake: Failed to execute command: vcsec could not execute command: genericError:GENERICERROR_UNAUTHORIZED charge-port-open: Failed to execute command: MESSAGEFAULT_ERROR_INSUFFICIENT_PRIVILEGES

Are these two problems fixable ?

Originally posted by @erikgieseler in https://github.com/teslamotors/vehicle-command/issues/230#issuecomment-2050077059

sethterashima commented 5 months ago

Thanks for the report. This will require a vehicle firmware update to fix.

erikgieseler commented 4 months ago

Is there any news on this?

stumbaumr commented 3 months ago

Is there any news on this? Reading the State of Charge (SoC) is also required to allow the "charging_manager" start fast charging to a minimum SoC and then continue with PV-based charging.

sethterashima commented 3 months ago

Is there any news on this?

Support for wake was merged into a coming firmware release.

Support for open/closing the charge port by Charging Manager keys makes sense intuitively, but I'm having second thoughts on that because the role was initially intended for remote management. What's the use case where it would be helpful to have a Charging Manager open/close the ports? Presumably there's a human nearby with a more privileged role in cases where this would be useful.

stumbaumr commented 3 months ago

What's the use case where it would be helpful to have a Charging Manager open/close the ports?

You come home, park the car and as Home Assistant knows the car is home and since the saying is "Steht er, dann lädt er" it opens the charge port as soon as you go in park. Opening the garage door -> Home assistant unlocks the charge port...

erikgieseler commented 3 months ago

Is there any news on this?

Support for wake was merged into a coming firmware release.

Support for open/closing the charge port by Charging Manager keys makes sense intuitively, but I'm having second thoughts on that because the role was initially intended for remote management. What's the use case where it would be helpful to have a Charging Manager open/close the ports? Presumably there's a human nearby with a more privileged role in cases where this would be useful.

Of course, you can also directly select a role with the highest rights and send the commands via BLE. However, for security reasons alone, you should select a role with minimal rights. The Charging Manager role would be well suited for this.

pkuehnel commented 2 months ago

Support for wake was merged into a coming firmware release.

Great news. Any idea of the Version number when this will be possible?

rcasta74 commented 2 weeks ago

Support for wake was merged into a coming firmware release.

I got recently the update to 2024.26.7 but I still get GENERICERROR_UNAUTHORIZED using a key with role charging_manager. What's the firmware version that bring this feature? Thanks.