teslamotors / vehicle-command

Apache License 2.0
442 stars 101 forks source link

Climate missing override parameter? #310

Open stx opened 1 month ago

stx commented 1 month ago

When you start the climate in the Tesla app with a door open it prompts for an override. Presumably using the same manual_override parameter that exists in other commands like Defrost?

That override is present on some commands in the SDK but is missing here: https://github.com/teslamotors/vehicle-command/blob/e8634aa8ac74282ab195edc462a86b1f87f451de/pkg/vehicle/climate.go#L38

zhy2020 commented 1 month ago

Hello, can I control the air conditioner through ble? I look at the code as if it is calling the Internet method

sethterashima commented 1 month ago

@stx The Manual Override bool is defined in the protobuf built by the method you linked: https://github.com/teslamotors/vehicle-command/blob/main/pkg/protocol/protobuf/car_server.proto#L142. Be careful about setting it to true; IIRC, it also overrides dog mode and low SoC, and so, as the name suggests, should never be set automatically without explicit manual confirmation.

There's a pending PR that will likely conflict with a quick fix, so I'd prefer to wait it gets merged.

@zhy2020 Please keep comments on topic. The example BLE program shows how to accomplish what you're after.

stx commented 1 month ago

@stx The Manual Override bool is defined in the protobuf built by the method you linked: https://github.com/teslamotors/vehicle-command/blob/main/pkg/protocol/protobuf/car_server.proto#L142. Be careful about setting it to true; IIRC, it also overrides dog mode and low SoC, and so, as the name suggests, should never be set automatically without explicit manual confirmation.

There's a pending PR that will likely conflict with a quick fix, so I'd prefer to wait it gets merged.

@zhy2020 Please keep comments on topic. The example BLE program shows how to accomplish what you're after.

Makes total sense. Thank you!