Pull Rewrite asm in C into master branch

teslaworksumn / HeadMaster

DMX parsing and I2C output for the master Animatronic Heads controller

MIT License

2 stars 0 forks source link

Pull Rewrite asm in C into master branch #15

Closed kevana closed 11 years ago

taylortrimble commented 11 years ago

Can we merge master into this so the diff I have to look at is littler? @aterlumen

taylortrimble commented 11 years ago

Holy :poop: 5ae84f696249b356cfafcaa1d06f362bfcd6d76c is one of the most beautiful commits I've ever seen. That's some sexy code!

I've added a few initial line comments on style, along the lines of:

const int DMXConstantName;
int DMXGlobalName;
void DMXFunctionName(void) {}

To make it more framework-like. I'll go over it for accuracy later. But holy shit. Nice work @aterlumen!

taylortrimble commented 11 years ago

Also, maybe we could move the code out of the header file? :stuck_out_tongue_winking_eye:

kevana commented 11 years ago

I think unless @tylrtrmbl finds any more logic errors in DMXlib.h this is ready to pull into master.

taylortrimble commented 11 years ago

This is one of the best code ports I've ever seen. Hurrah! after all the stylistic, spacing, and other fixes I mentioned in the last diff and 51d5916bf1357f2d695b44270cfc423e765bc8fd are done, it's good to pull! :shipit:

kevana commented 11 years ago

@tylrtrmbl One last look? I think we're good to go here.

taylortrimble commented 11 years ago

:sparkles: