search

teslaworksumn / HeadMaster

DMX parsing and I2C output for the master Animatronic Heads controller
MIT License
2 stars 0 forks source link

Pull out Magic numbers #32

Closed taylortrimble closed 11 years ago

taylortrimble commented 11 years ago

Replacing integer constants with #define directives, and the rest with const declarations. Thanks @aterlumen for the commits!

taylortrimble commented 11 years ago

I know there's a few more constants to hit here; @CrasherCourse can you sniff them out and zap them?

kevana commented 11 years ago

I looked through all of the code, I think that's the last one.

taylortrimble commented 11 years ago

I found a couple more:

kevana commented 11 years ago

I grabbed everything except the mapDmxToServo ones, not sure what you'd want to call them.

taylortrimble commented 11 years ago

Something like SERVO_BIT_OFFSET and SERVO_MIN_VALUE should be sufficient, but you can pick what you like and Kyle or I will say something if we don't like it.

taylortrimble commented 11 years ago

Okay, do you see anything else?

kevana commented 11 years ago

Nope, that was the only build error I got On Nov 22, 2012 12:51 AM, "Taylor Trimble" notifications@github.com wrote:

Okay, do you see anything else?

— Reply to this email directly or view it on GitHubhttps://github.com/teslaworksumn/HeadMaster/pull/32#issuecomment-10625247.

taylortrimble commented 11 years ago

There's something up with me backing out commits, and I don't want to submit this with 2 huge commits that undo each other, so I'm just going to manually merge.

taylortrimble commented 11 years ago

Looks like my plan didn't work, but whatever I guess. Happy coding!