search

tesonep / pharo-testWorkers

4 stars 4 forks source link

Change error handling #14

Closed sonibla closed 3 years ago

sonibla commented 3 years ago

Hello there

This PR tries to solve https://github.com/tesonep/pharo-testWorkers/issues/13

Feel free to improve or give me suggestions, I don't know if it was the best thing to do when getting a network error

Error handling responsibility has moved to TWAbstractConnected >> processRequest, I improved the behavior in case of NetworkError

Now when a runner has a connection error, it restarts by itself

Issue I had when testing: after 7 hours of running tests, all queues were suddenly removed from RabbitMQ so tests stopped, I have no idea why it happened and I don't know if it's related to my changes

sonibla commented 3 years ago

Update: the RabbitMQ crash i got after 7 hours was unrelated, I successfully ran all my tests in 8 hours