search

tespkg / actions-cache

Cache to S3 storage with official actions/cache@v2 fallback
MIT License
75 stars 31 forks source link

not saving cache on exact key hit #10

Closed royra closed 2 years ago

royra commented 2 years ago

Replicates the behavior of GitHub's cache action, and saves time on builds.

jgoux commented 2 years ago

I was going to open an issue about it, thanks for this @royra !

royra commented 2 years ago

Thanks for your contribution, can you resolve the conflicts and push?

@jackieli-tes done

jackieli-tes commented 2 years ago

before merging, can you add a test for this?

royra commented 2 years ago

before merging, can you add a test for this?

I would extend any existing tests to include this functionality, however it seems like no tests for save exist.

jackieli-tes commented 2 years ago

Hmmm, you're right on this. The tests are all integration tests that's done using the actions. No unit test exists atm. And this one should be tested with unit test.

Will merge this. And defer the test situation.