search

tessel / colony-compiler

[UNMAINTAINED] "Compiles" JS to Lua to run on Colony.
Other
80 stars 16 forks source link

`arguments` object regression #40

Closed kevinmehall closed 9 years ago

kevinmehall commented 9 years ago

1b0ad2a should be reverted or made conditional in cli on the device running the (currently unmerged) tessel/runtime#706.

Using cli @ 0.3.20, with firmware 0.1.26:

> (function() { console.log(arguments) })(1,2,3,4)
{
 0 : false,
 1 : undefined,
 2 : 1,
 3 : 2,
 4 : 3,
 5 : 4,
 length : 6
}

Incidentally, this bug makes all tests powered by tinytap fail.

I've unpublished cli @ 0.3.20 due to this regression. I recommend in the future that cli updates be installed on rampart and run through a test_all before release. colony-compiler is just as important to the success of those tests as runtime.

kevinmehall commented 9 years ago

Fixed by #41