tessel / openwrt-tessel

OpenWrt build scripts and package feed for Tessel 2
Other
32 stars 14 forks source link

Node v6.11.3 #75

Closed huseyinkozan closed 5 years ago

huseyinkozan commented 7 years ago

Cleaned libicu and updated to Node 6.11.3.

HipsterBrown commented 7 years ago

@huseyinkozan Why was libicu removed? Is that something that changed with Node 6?

huseyinkozan commented 7 years ago

I added libicu for a intl build, but node is not using it. Node 6 runs without intl support.

HipsterBrown commented 7 years ago

Node 6.11.2 Release Notes -> https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md#6.11.2

rwaldron commented 7 years ago

@HipsterBrown we don't want to build with ICU either way (the deps are massive)

rwaldron commented 7 years ago

The only thing holding me up on this is that t2-release doesn't work as intended anymore and I'm still in the process of updating it. Aside from that, I could do it manually like we did in the last release, but I won't do that on a Friday ;)

huseyinkozan commented 7 years ago

There is a libicu package at master branch : https://github.com/openwrt/packages/tree/master/libs/icu. The first one that I added was not complete. I built it the official one with a small modification. If anyone try to integrate, I can add it to this PR.

rwaldron commented 7 years ago

Just to make sure I still understand correctly: We really do not want to ship built-in ICU data, it's too large.

huseyinkozan commented 7 years ago

https://github.com/nodejs/node/wiki/Intl#q-by-how-much-do-the-various-options-affect-the-on-disk-sizes https://github.com/nodejs/node/issues/2300

I think, we dont need it

huseyinkozan commented 7 years ago

Actually my last trial was for enable the inspector. It depends on intl : https://github.com/nodejs/node/blob/v6.x/configure#L1291

Anyway, old fashion console.log() is another option

tikurahul commented 7 years ago

@huseyinkozan - inspector will be an amazing feature for Tessel. What are the missing pieces to enable that ?

huseyinkozan commented 7 years ago

@tikurahul After enable the system icu with --with-intl=system-icu flag, I got an error that complains about cannot find uchar.h

With the modified official libicu package, I got these uchar.h files:

$ find build_dir -name uchar.h
build_dir/host/icu4c-59.1/common/unicode/uchar.h
build_dir/host/icu/source/common/unicode/uchar.h
build_dir/target-mipsel_24kec+dsp_uClibc-0.9.33.2/node-v6.11.2/deps/icu-small/source/common/unicode/uchar.h

But I cannot find any CFLAG to give it a correct path. Maybe we need to change install path, but dont know.

The small modification is replacing $(STAGING_DIR_HOSTPKG) with $(STAGING_DIR)/host.

huseyinkozan commented 7 years ago

Updated to v6.11.3. Built but not write to Tessel.

rwaldron commented 7 years ago

I'd like to do a release next week. I will try to make the requisite time for that

huseyinkozan commented 7 years ago

Ok, thanks Rick.

I had also tried to build v8.4.0, but got an error about std::nearbyint. Just want to inform about

rwaldron commented 7 years ago

I've just completed a build and updated a Tessel 2 locally. My next steps are to run a few common programs (from Sparkfun and our own tutorials) on the updated Tessel 2. Once that's complete, I will do the final push. I estimate no later than Thursday

huseyinkozan commented 7 years ago

Ok, thanks. Ask me if I can do something.

Not related, but I am fihgting a memory issue. My project grown so much. Trying to minimize it. Any methods to decrease RAM usage ?

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

Edit: Sorry, was a silly question. I may try profiling at computer before push it.

rwaldron commented 7 years ago

Edit: Sorry, was a silly question. I may try profiling at computer before push it.

That was going to be my suggestion :)

nodebotanist commented 5 years ago

Does this need to be closed?

HipsterBrown commented 5 years ago

@nodebotanist Yes, we're now on Node 8 support. Thanks for triaging. :clap: