Why does _b reimplement parseInt(n, 2)?

tessel / rf-nrf24

[UNMAINTAINED] Pure-JavaScript nRF24L01 driver library

6 stars 2 forks source link

Why does _b reimplement parseInt(n, 2)? #9

Open rwaldron opened 10 years ago

rwaldron commented 10 years ago

https://github.com/tessel/rf-nrf24/blob/master/magicnums.js#L3-L10

rwaldron commented 10 years ago

Note: I'm only filing this because using parseInt(..., 2) worked fine when I tested with colony. Also, this link: https://github.com/tessel/beta/issues/206 is a 404.

johnnyman727 commented 10 years ago

@rwaldron, you're right – since parseInt was fixed, _b can be replaced.

rwaldron commented 10 years ago

Awesome.

rwaldron commented 10 years ago

I'll submit a patch for this.